Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIGITAL-249: Implement Guides landing page #102

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

DIGITAL-249: Implement Guides landing page #102

wants to merge 6 commits into from

Conversation

omerida
Copy link
Contributor

@omerida omerida commented Jan 6, 2025

Jira ticket

DIGITAL-249

Purpose

  • Add view to display guide pages with guide weight.
  • Render each guide in usa-card template

Includes the following PRs that must be merged first

DIGITAL-204

Deployment and testing

Local Setup

lando si should be sufficient.

QA/Testing instructions

  • Only guide pages with a guide weight (not empty) display on guides page
  • Guides are sorted in ascending guide weight order
  • Responsive USA Cards markup is rendered

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@omerida omerida requested a review from mattsqd January 6, 2025 16:53
@omerida
Copy link
Contributor Author

omerida commented Jan 10, 2025

@mattsqd I'm setting this to draft and we should revisit this after merging #128. For building this page, we need some other way to identify the guides to show than just "guide pages with guide weight", since one of the cards that has to show up in this list is the new Guide Landing page content type.

@omerida omerida marked this pull request as draft January 10, 2025 17:36
@casey-rapnicki-bixal casey-rapnicki-bixal force-pushed the develop branch 5 times, most recently from 4a4650e to 78521e0 Compare January 16, 2025 23:57
@omerida
DIGITAL-249: Implement Guides landing page
853bc2b 
* Add view to display guide pages with guide weight.
* Render each guide in usa-card template
@omerida
DIGITAL-254: Removing featured image field from guides.
b300d84
@omerida
DIGITAL-249: Style HCD guide landing page
7ea6f1c 
* Re-use the USA card partial to render guides listed on HCD guides landing page.
* Tweak the kicker shown on each of the guide-related landing pages.
* Add guide weight field to the guide landing content type and include its nodes in the guides landing page.
@omerida omerida force-pushed the feature/DIGITAL-249-guide-landing-page branch from f30a4bf to 7ea6f1c Compare January 22, 2025 01:09
@omerida omerida marked this pull request as ready for review January 22, 2025 22:02
@omerida
Copy link
Contributor Author

omerida commented Jan 22, 2025

@mattsqd This is ready for review now and incorporates the updates for default content from #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsqd mattsqd Awaiting requested review from mattsqd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omerida