-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/poam link #1024
Feature/poam link #1024
Conversation
see #934 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Just a couple things related to the style guide and to help make this PR easier to look at.
src/validations/constraints/content/ssp-component-has-poam-link-INVALID.xml
Show resolved
Hide resolved
src/validations/constraints/content/ssp-poam-link-has-resource-fragment-INVALID.xml
Show resolved
Hide resolved
src/validations/constraints/content/ssp-poam-link-references-valid-resource-INVALID.xml
Show resolved
Hide resolved
src/validations/constraints/content/ssp-poam-resource-has-oscal-link-INVALID.xml
Show resolved
Hide resolved
@Gabeblis can you take a look? i added some more checks so we don't have to check alphabetical order, or duplicate constraints |
converting to draft while i pull out style guide edits |
UPDATE: Nevermind, I see I missed the next few emails and comments. |
Committer Notes
adding some poam item related constraints
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.