Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/poam link #1024

Closed
wants to merge 15 commits into from
Closed

Feature/poam link #1024

wants to merge 15 commits into from

Conversation

wandmagic
Copy link

@wandmagic wandmagic commented Dec 23, 2024

Committer Notes

adding some poam item related constraints

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@wandmagic
Copy link
Author

see #934

@wandmagic wandmagic marked this pull request as ready for review December 23, 2024 19:44
@wandmagic wandmagic requested a review from a team as a code owner December 23, 2024 19:44
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Just a couple things related to the style guide and to help make this PR easier to look at.

@wandmagic
Copy link
Author

@Gabeblis can you take a look? i added some more checks so we don't have to check alphabetical order, or duplicate constraints

@wandmagic wandmagic requested a review from Gabeblis December 27, 2024 15:51
@wandmagic wandmagic marked this pull request as draft December 27, 2024 16:39
@wandmagic
Copy link
Author

converting to draft while i pull out style guide edits

@wandmagic wandmagic closed this Dec 30, 2024
@aj-stein-gsa
Copy link
Contributor

aj-stein-gsa commented Dec 30, 2024

Are you reopening this? I also get part-way through a PR and then have to start over with reviews. 😅

UPDATE: Nevermind, I see I missed the next few emails and comments.

@wandmagic wandmagic mentioned this pull request Dec 30, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Each Interconnection, Service, or Software Connecting to an External Systems Must be Linked to a POA&M Entry
3 participants