Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NanoVectorDBStorage upsert to use hash values for IDs #359

Closed

Conversation

FatRicePaddyyyy
Copy link

  • In the delete_entity method, a hash value is calculated when deleting an entity.
  • On the other hand, in the upsert method, the index was used directly as the ID when adding an entity.
  • Therefore, I modified the upsert method to also calculate a hash value.

@LarFii
Copy link
Collaborator

LarFii commented Dec 2, 2024

Thanks for your suggestion! But the hash value is already calculated in operate.py before calling the upsert method.

@FatRicePaddyyyy
Copy link
Author

I see. Sorry for jumping to conclusions. I'll cancel the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants