Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix to introduced problem in ollama and lollm #608

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

ParisNeo
Copy link
Contributor

Hi,

Sorry. I just found out that passing the headers to the ollama and lollms directly from llm has a conflict with another header generated inside this so we need to rewrite it.

To fix the problem I just removed the header asignment temporarily and I'll rewrite it this evening.

I tested it last night but it seems that I wasn't testing the right version (my bad)

Sorry for the error. This should fix it.
Have a nice day

@LarFii
Copy link
Collaborator

LarFii commented Jan 20, 2025

No worries. But there are some linting errors that need to be fixed.
Thanks, and have a great day!

@ParisNeo
Copy link
Contributor Author

Ok, I suspect that the real problem comes fom another update beceause yesterday it worked on my PC.
I'll analyze the problem more then make a pull request when nready. I'll also do linting

@ParisNeo
Copy link
Contributor Author

OK, found the problem and fixed it. Now everything is working fine. We just need to update the linting and we're back on track.

@ParisNeo
Copy link
Contributor Author

Would you please accept and merge the update then do a linting with pre-commit. I can't do that immediately. I can do it this evening when I'm back home, but It would be wize not to keep the repo with a serious error like this for long.

Thanks

@ParisNeo
Copy link
Contributor Author

TO sum up the problem:
I have added the possibility to access lollms or ollama behind a secure access with BEARING Key.

In the code I specified that the header will be None if no key is specified.
But it shouldn't be none, it should at least be an empty dict or a dict with content type.

So I have updated this so that if no key is pecified, we use a default header.

@LarFii
Copy link
Collaborator

LarFii commented Jan 20, 2025

Sure, no problem.

@LarFii LarFii merged commit d9a2285 into HKUDS:main Jan 20, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants