Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React Router detection and update Remix implies field #69

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix React Router detection and update Remix implies field #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
955aa4a
Fix React Router detection and update Remix implies field
brookslybrand Oct 15, 2024
42dcb40
Update src/technologies/r.json
tunetheweb Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/technologies/r.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,9 +633,9 @@
"icon": "React Router.svg",
"implies": "React",
"oss": true,
"scriptSrc": [
"(?:/react-router(@|/)([\\d.]+)(?:/[a-z]+)?)?/react-router(?:\\.min)?\\.js\\;version:\\2"
],
"js": {
"__reactRouterVersion": "([\\d\\.]+)\\;version:\\1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only included in version 6. Any reason not to include the other detection too to pick up older versions?

Then again the number of sites found with this is only a couple of hundred so not massive deal to lose them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's more the fact that the old regex really wasn't picking up much of anything at all. I'm fine with leaving it in, I just figured

  1. We're not losing much
  2. The definition remains simple and we're not carrying a legacy definition devoid of this context

Happy to revert this deletion if you feel strongly about though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope that all makes sense to me. Just making sure you’d considered that. Let’s merge.

},
"website": "https://reactrouter.com"
},
"Reactive": {
Expand Down Expand Up @@ -1337,7 +1337,8 @@
"description": "Remix is a React framework used for server-side rendering (SSR).",
"icon": "Remix.svg",
"implies": [
"React"
"React",
"React Router"
],
"js": {
"__remixContext": ""
Expand Down