Porting the accounts info command to TS #1342
Conversation
|
|
||
| exports.builder = yargs => { | ||
| export function builder(yargs: Argv): Argv<AccountInfoArgs> { |
There was a problem hiding this comment.
We went back and forth on some ideas for how to type the builder function in a more useful way, but ultimately we landed on this because it's the simplest option. We can revisit this later on if we feel like we're not getting any value out of it. The main value of TS in these command files will be in the handler methods. We have acceptance tests (coverage will be improving soon) that will catch breaking changes to the builder methods.
|
|
||
| const response = await getAccessToken( | ||
| personalAccessKey, | ||
| personalAccessKey!, |
There was a problem hiding this comment.
Should we throw an error if personalAccessKey isn't in the config? I could go either way
There was a problem hiding this comment.
I think we should, but I'm trying to avoid making any code changes as a part of this port. I can do that as a follow up PR though!
|
|
||
| logger.log(i18n(`${i18nKey}.name`, { name })); | ||
| logger.log(i18n(`${i18nKey}.name`, { name: name! })); |
There was a problem hiding this comment.
Might just try to find a way to make all the config fields guaranteed to exist (in typescript's eyes) when i redo it
Description and Context
Porting the
hs accounts infocommand to TS. I'm only porting a single command in this so we can agree on a pattern for how the commands should look before I port more of them.Screenshots
TODO
Who to Notify