chore: Convert lib/tests to TypeScript
#1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemmerle
requested review from
brandenrodgers,
camden11 and
joe-yeager
as code owners
kemmerle
commented
Jan 17, 2025
camden11
reviewed
Jan 17, 2025
| APP_FUNCTION: 'APP_FUNCTION', | ||
| AUTOMATION_ACTION: 'AUTOMATION_ACTION', | ||
| REACT_EXTENSION: 'REACT_EXTENSION', | ||
| } as const; |
There was a problem hiding this comment.
You can just grab these from LDL
There was a problem hiding this comment.
I was getting an error when I attempted that--it didn't look to me like the enums folder where this is located had an export assigned in LDL's package.json. Am I missing anything?
There was a problem hiding this comment.
Oh interesting, I didn't realize those aren't exported. That's fine then!
camden11
reviewed
Jan 17, 2025
camden11
previously approved these changes
Jan 21, 2025
| APP_FUNCTION: 'APP_FUNCTION', | ||
| AUTOMATION_ACTION: 'AUTOMATION_ACTION', | ||
| REACT_EXTENSION: 'REACT_EXTENSION', | ||
| } as const; |
There was a problem hiding this comment.
Oh interesting, I didn't realize those aren't exported. That's fine then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
In this PR, I've converted the following files from
/lib/__tests__to TypeScript:commonOpts.test.tsdependencyManagement.test.tsprojectsLogManager.test.tsprojects.test.tsserverlessLogs.test.tsis the final file from/lib/__tests__that needs TS conversion, but the prerequisite files haven't been converted yet. I plan to make that its own PR.TODO
Who to Notify
@brandenrodgers @camden11 @joe-yeager