Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): restore the Kafka 4.0.0 FV #3055

Merged
merged 4 commits into from
Jan 7, 2025
Merged

fix(ci): restore the Kafka 4.0.0 FV #3055

merged 4 commits into from
Jan 7, 2025

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Jan 7, 2025

Now that KAFKA-17616 has landed on the kafka 4.0 branch it can no longer be run in ZooKeeper mode.

We'll need to work on a strategy for templating the docker-compose.yml in order to run KRaft quorum services instead of ZooKeeper if KAFKA_VERSION >= 4.0.0, but for now just pin to a commit before the removal started.

dnwe added 2 commits January 7, 2025 10:00
In order to test group coordinator failover, we need at least 2 replicas
for each __consumer_offsets partition so that an ISR can takeover
leadership when the coordinator broker is shutdown.

Signed-off-by: Dominic Evans <[email protected]>
Docker expect compose to be installed as a CLI plugin and called via
`docker compose` these days, so mirror that in our CI and call it as
such within the FV tests

Use the opportunity to bump the CI version to the latest release too.

Signed-off-by: Dominic Evans <[email protected]>
@dnwe dnwe added the ci label Jan 7, 2025
dnwe added 2 commits January 7, 2025 10:29
Long term Kafka 4.0.0 will be Kraft-only and won't support running in
ZooKeeper mode anymore. For now we can pin to a commit from the 4.0
branch just before KAFKA-17616 Remove KafkaServer started being
delivered. In the future we'll need to enhance our docker-compose.yml to
run KRaft brokers when KAFKA_VERSION >= 4.0.0

Signed-off-by: Dominic Evans <[email protected]>
@dnwe dnwe changed the title chore(ci): make the FV on Kafka 4.0.0 more reliable fix(ci): restore the Kafka 4.0.0 FV Jan 7, 2025
Copy link
Collaborator

@hindessm hindessm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnwe dnwe merged commit 85a9c9f into main Jan 7, 2025
15 checks passed
@dnwe dnwe deleted the dnwe/fix-fv branch January 7, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants