Histogram2d #2262
Open
Histogram2d #2262
+537
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderKalistratov
force-pushed
the
histogram2d
branch
3 times, most recently
from
8cfd5db to
541e7d9
Compare
AlexanderKalistratov
force-pushed
the
histogram2d
branch
from
541e7d9 to
58dbab3
Compare
AlexanderKalistratov
force-pushed
the
histogram2d
branch
from
58dbab3 to
a692ff5
Compare
AlexanderKalistratov
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
|
@antonwolfy @vlad-perevezentsev ready for review |
antonwolfy
reviewed
Jan 17, 2025
|
@antonwolfy please re-review |
antonwolfy
reviewed
Jan 22, 2025
antonwolfy
reviewed
Jan 22, 2025
antonwolfy
reviewed
Jan 22, 2025
antonwolfy
reviewed
Jan 22, 2025
antonwolfy
reviewed
Jan 22, 2025
antonwolfy
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
I left one minor comment, but overall LGTM! Thank you @AlexanderKalistratov
Co-authored-by: Anton <[email protected]>
|
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_24 ran successfully. |
antonwolfy
reviewed
Jan 23, 2025
| @@ -54,6 +54,19 @@ def to_supported_dtypes(dtypes, supported_types, device): | |||
| def is_castable(dtype, stype): | |||
| return _can_cast(dtype, stype, has_fp16, has_fp64) | |||
|
|
|||
| if not isinstance(supported_types, Iterable): | |||
| supported_types = (supported_types,) | |||
There was a problem hiding this comment.
It seems missing to be covered by a test
antonwolfy
reviewed
Jan 23, 2025
| if isinstance(dtypes, Iterable): | ||
| sdtypes_elem = supported_types[0] | ||
| if not isinstance(sdtypes_elem, Iterable): | ||
| raise ValueError( |
There was a problem hiding this comment.
And that error case as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
histogram2dvia already existing functionality ofhistogramdd.histogram2daccepts 2 different arrays, whilehistogramddaccepts single two-dimensional array.In order to avoid double copy (first to single array, second to supported type)
histogram2dperform type checks before calling tohistogramdd.