Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recently updated tests to run properly when no fp64 #2273

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Update recently updated tests to run properly when no fp64 #2273

merged 4 commits into from
Jan 22, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jan 22, 2025 •
edited
Loading

Some of the tests which were updated by latest PRs don't work properly when running on a device without fp64 support.
The PR is intended to resolve that and to implement proper check of the resulting arrays for impacted tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jan 22, 2025
vlad-perevezentsev
vlad-perevezentsev approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.181%. remained the same
when pulling 2a6001a on fix-new-test-on-iris
into 094ab7c on master.

@github-actions GitHub Actions
Copy link
Contributor

Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_18 ran successfully.
Passed: 954
Failed: 0
Skipped: 46

@antonwolfy antonwolfy merged commit 451c2b3 into master Jan 22, 2025
57 of 60 checks passed
@antonwolfy antonwolfy deleted the fix-new-test-on-iris branch January 22, 2025 17:27
github-actions bot added a commit that referenced this pull request Jan 22, 2025
@github-actions
Update recently updated tests to run properly when no fp64 (#2273)
636e4cd 
Some of the tests which were updated by latest PRs don't work properly
when running on a device without fp64 support.
The PR is intended to resolve that and to implement proper check of the
resulting arrays for impacted tests. 451c2b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonwolfy @coveralls @vlad-perevezentsev