Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Makie 0.20 #12

Merged
merged 11 commits into from
Nov 25, 2023
Merged

support Makie 0.20 #12

merged 11 commits into from
Nov 25, 2023

Conversation

jwahlstrand
Copy link
Member

@jwahlstrand jwahlstrand commented Nov 19, 2023

Work in progress "port" to Makie version 0.20.

Also uses more efficient signal connection methods for events and adds more controls for attributes.

@codecov-commenter
Copy link

Codecov Report

Attention: 275 lines in your changes are missing coverage. Please review.

Comparison is base (bd269ec) 34.50% compared to head (920f72f) 37.62%.

Files Patch % Lines
src/attributes.jl 6.32% 74 Missing ⚠️
src/scene.jl 0.00% 73 Missing ⚠️
src/events.jl 36.25% 51 Missing ⚠️
src/settings_widgets.jl 0.00% 31 Missing ⚠️
src/widget.jl 15.62% 27 Missing ⚠️
src/screen.jl 69.69% 10 Missing ⚠️
src/window.jl 87.32% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   34.50%   37.62%   +3.11%     
==========================================
  Files           6        8       +2     
  Lines         681      893     +212     
==========================================
+ Hits          235      336     +101     
- Misses        446      557     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwahlstrand jwahlstrand marked this pull request as ready for review November 25, 2023 02:46
@jwahlstrand jwahlstrand merged commit e367796 into main Nov 25, 2023
1 check passed
@jwahlstrand jwahlstrand deleted the v2 branch November 25, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants