Make GHA workflow reusable #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows people to use the workflow without copying its entirety, similar to calling an action. More info: https://docs.github.com/en/actions/using-workflows/reusing-workflows
SaschaMann
commented
Mar 9, 2022
| secrets: | ||
| DOCUMENTER_KEY: | ||
| description: 'An SSH deploy key. See docs for more info.' | ||
| required: true |
There was a problem hiding this comment.
Is this actually required? I'm never sure.
If not:
Suggested change
| required: true | |
| required: false |
|
Would it be better to first get #379 merged? |
|
Oops, I forgot about that PR. The composite action is more flexible and there's not much point in having both in this case. |
|
What do end-users tend to prefer using? Composite workflows or re-usable workflows? |
|
I don't really know, they're both relatively new so I'm not sure what people prefer for workflows/actions that are fairly simple like this one. The main advantage of the composite action would be that people can run things before or after it, the workflow is every so slightly shorter (doesn't require setting an OS for example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to use the workflow without copying its entirety, similarly to calling an action.
More info: https://docs.github.com/en/actions/using-workflows/reusing-workflows
Test run: https://github.com/julia-actions/Example.jl/runs/5474751558?check_suite_focus=true (for a scheduled test run, you might have to check back in a few hours)
@DilumAluthge do you happen to have a way to test if it actually works when a dependency has to be bumped? Some kind of example package? That way the secrets could be tested properly