Start work on an Object API for representing a remote cloud object #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import CloudBase: AbstractStore, CloudCredentials | ||
|
|
||
| struct Object{T <: AbstractStore, C <: Union{CloudCredentials, Nothing}} | ||
| store::T |
There was a problem hiding this comment.
i'm guessing it might be worth store being concretely typed, since we're going to be dispatching on that often? I wonder if we should add conveniences like const S3Object = Object{AWS.Bucket}?
|
@Drvi, @nickrobinson251, this is ready for review on the |
Drvi
reviewed
Oct 23, 2022
|
|
||
| Base.eof(x::IOObject) = x.pos > length(x.object) | ||
|
|
||
| function Base.readbytes!(x::IOObject, dest::AbstractVector{UInt8}, n::Integer=length(dest)) |
There was a problem hiding this comment.
To have the same semantics as Base.readbytes!, we should grow the dest array as necessary to store the incomming bytes. Not that we rely on this in ChunkedCSV.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.