Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change content source & REX Pull provider #11265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stejskalleos
Copy link
Contributor

What are the changes introduced in this pull request?

Run configuration for the REX Pull provider only if necessary.
Implemented the same way as in the Configure host for new content source job template

Considerations taken when implementing this change?

https://issues.redhat.com/browse/SAT-24795

What are the testing steps for this pull request?

Change the content source for the host and verify that the steps for configuring the pull provider haven't been run.

@stejskalleos
Copy link
Contributor Author

Note: This is more of a minimalistic approach.
The other way would be to add a new field to the UI form, implement inputs for the job template, and so on.

@ianballou
Copy link
Member

We'll get a review on this soon.

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the script manually on a host where /etc/yggdrasil/config.toml does not exist

Confirmed that the script does not try to configure yggdrasil in that case.

LGTM 👍

@jeremylenz
Copy link
Member

@stejskalleos Can you please rebase? I think that may fix the failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants