Fixes #38142 - Add MultiCV methods to jail for hosts and activation keys reporting #11279
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
reviewed
Jan 23, 2025
| @@ -290,7 +290,7 @@ def check_cves | |||
| property :name, String, desc: 'Returns the name of the Activation Key.' | |||
| end | |||
| class Jail < ::Safemode::Jail | |||
| allow :name | |||
| allow :name, :content_view_environment_labels, :multi_content_view_environment? | |||
There was a problem hiding this comment.
I suppose the :multi_content_view_environment? was added just out of future helpfulness to users?
There was a problem hiding this comment.
Yeah. Figured it may save an RFE in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
With the MultiCV feature now available, the Host - Installed Products report now must handle multiple content view environments instead of just a single content view and lifecycle environment. This makes that possible, and also adds a few more methods to Jail that may be of use.
Goes with theforeman/foreman#10417
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Test together with the Foreman PR; see instructions there