Fixes to managing descriptor set allocation in a Metal argument buffer. #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix regression in MVKBitArray::getIndexOfFirstEnabledBit() that didn't continue searching beyond the initial start section. - After freeing the last descriptor set in Metal argument buffer, support replacing it with a longer descriptor set. - MVKMetalArgumentBuffer track encoded size of descriptor set. - MVKDescriptorPool: Determine the offset of allocated space in argument buffer for a descriptor set from the previous descriptor set allocation, instead of using a separate member variable.
billhollings
force-pushed
the
fix-ds-alloc-in-mtlargbuff
branch
from
3f1fb8a to
bdc646c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVKBitArray::getIndexOfFirstEnabledBit()that didn't continue searching beyond the initial start section.MVKMetalArgumentBuffertrack encoded size of descriptor set.MVKDescriptorPool: Determine the offset of allocated space in argument buffer for a descriptor set from the previous descriptor set allocation, instead of using a separate member variable.Replaces PR #2388.