Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSL: Fix argument buffer padding. #2320

Conversation

billhollings
Copy link
Contributor

@billhollings billhollings commented May 6, 2024

  • After padding a resource, retrieve either the next padded slot, or the next resource, in order to correctly offset the slot index.

Fixes issue #2198.

- After padding a resource, retrieve either the next padded slot,
  or the next resource, in order to correctly offset the slot index.
@billhollings billhollings merged commit e41d79f into KhronosGroup:vulkan-sdk-1.3.283-moltenvk May 6, 2024
6 checks passed
@billhollings billhollings deleted the fix-arg-buff-padding branch May 6, 2024 01:26
@HansKristian-Work
Copy link
Contributor

I cherry-picked this and pushed to main.

@billhollings
Copy link
Contributor Author

I cherry-picked this and pushed to main.

Thanks!

I'll move MoltenVK to that for the SDK release.

BTW...for future reference, although nice, it's not always necessary for you to rush to do that prior to an SDK release. MoltenVK retrieves based on a commit hash, so the branch hash is just as easy for MoltenVK to pull in as a main hash. The important thing of course is to make sure the branch changes (or something with the same functionality) make it into main at some point shortly afterwards though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants