Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Resource Aware Pool #901

Merged
merged 153 commits into from
Dec 6, 2024
Merged

Add a Resource Aware Pool #901

merged 153 commits into from
Dec 6, 2024

Conversation

kab163
Copy link
Contributor

@kab163 kab163 commented Aug 1, 2024

The resource aware pool will ensure that a data race will not occur when a stream (resource) attempts to reuse memory that is still be touched by a different stream (resource).

Still needed to be done:

  • Implement an official RAP test
  • Clean up example and add comments
  • Add documentation and cookbook recipe
  • Double check all the TODO comments (questions about whether or not a check is needed....)
  • change current_size to aligned_size

kab163 added 30 commits April 23, 2024 12:14
Copy link
Member

@davidbeckingsale davidbeckingsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only major concern is having to manually construct strings for allocate(name, size) method due to templated Resource constructor. If this is fixed in camp I think that would be a good idea.

src/umpire/Umpire.cpp Outdated Show resolved Hide resolved
src/umpire/Umpire.hpp Outdated Show resolved Hide resolved
src/umpire/Umpire.hpp Outdated Show resolved Hide resolved
src/umpire/Umpire.hpp Outdated Show resolved Hide resolved
src/umpire/event/event.hpp Show resolved Hide resolved
src/umpire/strategy/ResourceAwarePool.cpp Outdated Show resolved Hide resolved
src/umpire/strategy/ResourceAwarePool.cpp Outdated Show resolved Hide resolved
src/umpire/strategy/ResourceAwarePool.cpp Show resolved Hide resolved
src/umpire/strategy/ResourceAwarePool.cpp Show resolved Hide resolved
src/umpire/strategy/ResourceAwarePool.hpp Outdated Show resolved Hide resolved
@kab163
Copy link
Contributor Author

kab163 commented Dec 5, 2024

My only major concern is having to manually construct strings for allocate(name, size) method due to templated Resource constructor. If this is fixed in camp I think that would be a good idea.

I think I've addressed this and the other comments from the review

@kab163
Copy link
Contributor Author

kab163 commented Dec 6, 2024

Issue here: #925

Copy link
Member

@davidbeckingsale davidbeckingsale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kab163 kab163 merged commit dd8d2ad into develop Dec 6, 2024
18 checks passed
@kab163 kab163 deleted the task/kab163/resource-aware-pool branch December 6, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants