-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Resource Aware Pool #901
Conversation
…ire into task/kab163/resource-aware-pool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only major concern is having to manually construct strings for allocate(name, size)
method due to templated Resource constructor. If this is fixed in camp I think that would be a good idea.
…ire into task/kab163/resource-aware-pool
…eases free chunks
…ire into task/kab163/resource-aware-pool
I think I've addressed this and the other comments from the review |
Issue here: #925 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
The resource aware pool will ensure that a data race will not occur when a stream (resource) attempts to reuse memory that is still be touched by a different stream (resource).
Still needed to be done: