Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync upstream with internal version #40

Merged
merged 27 commits into from
Jan 14, 2025
Merged

Sync upstream with internal version #40

merged 27 commits into from
Jan 14, 2025

Conversation

edwinans
Copy link
Member

@edwinans edwinans commented Dec 23, 2024 •
edited
Loading

  • Import changes from LexiFi.
  • Add a test for zero allocation of profiling on ocamlopt
  • Add test for JS
  • Fix GH Workflow for incompatible macOS compilers, and add ocaml.5, nodejs
  • Weekly build of CI

@edwinans edwinans force-pushed the edwinans@sync-upstream branch 3 times, most recently from ba37f6e to 440c469 Compare December 23, 2024 16:42
@edwinans edwinans force-pushed the edwinans@sync-upstream branch from 440c469 to a85ea0e Compare December 23, 2024 16:46
@edwinans edwinans marked this pull request as draft December 23, 2024 17:12
@edwinans edwinans marked this pull request as ready for review December 23, 2024 17:33
@edwinans edwinans force-pushed the edwinans@sync-upstream branch from 9731333 to 2160db8 Compare December 23, 2024 17:36
@edwinans edwinans force-pushed the edwinans@sync-upstream branch from 0ba7221 to 082f514 Compare December 23, 2024 17:49
@edwinans edwinans marked this pull request as draft January 13, 2025 14:03
@edwinans edwinans force-pushed the edwinans@sync-upstream branch from 7afb494 to 3f53400 Compare January 13, 2025 14:05
@edwinans edwinans force-pushed the edwinans@sync-upstream branch from 81a9e23 to fda4d70 Compare January 13, 2025 14:46
@edwinans edwinans marked this pull request as ready for review January 13, 2025 15:42
@edwinans edwinans requested a review from mlasson January 13, 2025 17:21
@edwinans
Copy link
Member Author

CI is fixed now, added a test on JS.
Reporting always zero allocated bytes for JS since Node/V8 heap is not only increasing, thus the number doesn't correspond really to allocated bytes for the program.

Ready for final review @mlasson.

@edwinans edwinans modified the milestones: Version 1.1, V1.5 Jan 13, 2025
mlasson
mlasson approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@mlasson mlasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please do not hesitate to publish a new version.

@edwinans edwinans merged commit 2498e10 into master Jan 14, 2025
18 checks passed
@edwinans edwinans deleted the edwinans@sync-upstream branch January 14, 2025 09:07
@edwinans
Copy link
Member Author

Please do not hesitate to publish a new version.

This is now done in ocaml/opam-repository#27263, can you check if everything is fine please @mlasson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlasson mlasson mlasson approved these changes

Assignees

@alainfrisch alainfrisch

@mlasson mlasson

Labels
None yet
Projects
None yet
Milestone
V1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@edwinans @mlasson @alainfrisch