Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add js_of_ocaml dep for tests, adapt test to ocaml.5.3 #42

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Add js_of_ocaml dep for tests, adapt test to ocaml.5.3 #42

merged 6 commits into from
Jan 15, 2025

Conversation

edwinans
Copy link
Member

@edwinans edwinans commented Jan 14, 2025 •
edited
Loading

@edwinans edwinans requested a review from mlasson January 14, 2025 14:19
@edwinans edwinans changed the title Add js_of_ocaml dep for tests Add js_of_ocaml dep for tests, adapt test to ocaml.5.3 Jan 14, 2025
mlasson
mlasson approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@mlasson mlasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwinans edwinans merged commit 72dc80c into master Jan 15, 2025
20 checks passed
@edwinans edwinans deleted the edwinans@js_of_ocaml-test-dep branch January 15, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlasson mlasson mlasson approved these changes

Assignees

@mlasson mlasson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwinans @mlasson