Simplify logic

Living-with-machines · Dec 18, 2024 · 58b39c3 · 58b39c3
1 parent 0ff4746
commit 58b39c3
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/t_res/geoparser/linking.py b/t_res/geoparser/linking.py
@@ -335,10 +335,8 @@ def disambiguation_scores(self, wikidata_links: List[ByDistanceLink], string_sim
                 distance_score = 1.0 - (distance / max_on_gb)
 
             relv_score = min(1.0, (string_similarity + link.normalized_score) / 2.0)
+            final_score = round((relv_score + distance_score) / 2, 3) if link.geodist is not None else 0.0
 
-            final_score = 0.0
-            if link.geodist is not None:
-                final_score = round((relv_score + distance_score) / 2, 3)
             ret[link.wqid] = final_score
         return ret