Refactor regions spec to not hard-code atypical regions #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regions spec has a hard-coded list of "atypical regions" which really just means regions which exist but are not available to us via the aws-sdk `describe_regions` API call. It would be simpler to just check that all of the regions that we do have access to are in the regions list. This would allow us to update the `config/regions.yml` list in an automated way.
|
I'm questioning how helpful this spec is, since the "online" list of regions is coming from a vcr rather than live then we aren't going to be testing if we missed any new regions. This will likely work unless AWS removes a region though. |
|
Checked commit agrare@8c13c5c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Fryguy
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regions spec has a hard-coded list of "atypical regions" which really just means regions which exist but are not available to us via the aws-sdk
describe_regionsAPI call.It would be simpler to just check that all of the regions that we do have access to are in the regions list. This would allow us to update the
config/regions.ymllist in an automated way.