Call sync_from_system before_sync_workers at startup #23309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23112 allowed non-rails workers to be marked as started even if they didn't go through run_single_worker with database access, specifically the opentofu-worker.
The issue here is that the threads which keep the list of current deployments and pods up to date are not started by
MiqServer#start_workers
, rather only the initial startup has completed and MiqServer has moved to theMiqServer#monitor_workers
loop. The result of this was everything worked if the server was started with the embedded_terraform role disabled and the role was enabled later, but if the role was enabled at startup thewait_for_started_workers
would never complete and timeout.Fixes ManageIQ/manageiq-providers-embedded_terraform#81