-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing vector space scene #4130
Open
henrikmidtiby
wants to merge
6
commits into
ManimCommunity:main
Choose a base branch
from
henrikmidtiby:Typing_vector_space_scene
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Typing vector space scene #4130
henrikmidtiby
wants to merge
6
commits into
ManimCommunity:main
from
henrikmidtiby:Typing_vector_space_scene
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/astral-sh/ruff-pre-commit: v0.9.1 → v0.9.2](astral-sh/ruff-pre-commit@v0.9.1...v0.9.2)
@@ -32,7 +32,7 @@ | |||
|
|||
from manim import config, logger | |||
from manim.constants import * | |||
from manim.mobject.geometry.line import Line | |||
from manim.mobject.geometry.line import Line, Vector |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
'Line' may not be defined if module is imported before module , as the of Line occurs after the cyclic of manim.mobject.text.tex_mobject.
'Line' may not be defined if module is imported before module , as the of Line occurs after the cyclic of manim.mobject.text.tex_mobject.
'Line' may not be defined if module is imported before module , as the of Line occurs after the cyclic of manim.mobject.text.tex_mobject.
'Line' may not be defined if module is imported before module , as the of Line occurs after the cyclic of manim.mobject.text.tex_mobject.
'Line' may not be defined if module is imported before module , as the of Line occurs after the cyclic of manim.mobject.text.tex_mobject.
'Line' may not be defined if module is imported before module , as the of Line occurs after the cyclic of manim.mobject.text.tex_mobject.
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Line' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Line' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Line' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Line' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Line' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading @@ -32,7 +32,7 @@ | |||
|
|||
from manim import config, logger | |||
from manim.constants import * | |||
from manim.mobject.geometry.line import Line | |||
from manim.mobject.geometry.line import Line, Vector |
Check failure
Code scanning / CodeQL
Module-level cyclic import Error
'Vector' may not be defined if module is imported before module , as the of Vector occurs after the cyclic of manim.mobject.text.tex_mobject.
'Vector' may not be defined if module is imported before module , as the of Vector occurs after the cyclic of manim.mobject.text.tex_mobject.
'Vector' may not be defined if module is imported before module , as the of Vector occurs after the cyclic of manim.mobject.text.tex_mobject.
'Vector' may not be defined if module is imported before module , as the of Vector occurs after the cyclic of manim.mobject.text.tex_mobject.
'Vector' may not be defined if module is imported before module , as the of Vector occurs after the cyclic of manim.mobject.text.tex_mobject.
'Vector' may not be defined if module is imported before module , as the of Vector occurs after the cyclic of manim.mobject.text.tex_mobject.
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Vector' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Vector' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Vector' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Vector' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading 'Vector' may not be defined if module
manim.mobject.geometry.line
Error loading related location
Loading manim.mobject.text.tex_mobject
Error loading related location
Loading definition
Error loading related location
Loading import
Error loading related location
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This PR adds type annotations to
vector_space_scene.py
.Motivation and Explanation: Why and how do your changes improve the library?
More work towards #3375
Links to added or changed documentation pages
Further Information and Comments
During work on the PR, a few inconsistencies between the existing implementation and the type annotations were found.
To find proper solutions to these, the following questions will have to be answered.
manim/_config/cli_colors.py
)manim/mobject/text/tex_mobject.py
), as some methods inmanim/scene/vector_space_scene.py
depend on these (see comment on line 945).Reviewer Checklist