Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump software.amazon.awssdk:cognitoidentity from 2.29.52 to 2.30.3 #1683

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2025

Bumps software.amazon.awssdk:cognitoidentity from 2.29.52 to 2.30.3.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps software.amazon.awssdk:cognitoidentity from 2.29.52 to 2.30.3.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:cognitoidentity
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 22, 2025
Copy link

stanzabot bot commented Jan 22, 2025

Summary

Updated the version of the software.amazon.awssdk:cognitoidentity dependency from 2.29.52 to 2.30.3 in the pom.xml file.

File Change summary
pom.xml Changed the version of the software.amazon.awssdk:cognitoidentity dependency from 2.29.52 to 2.30.3.

Copy link

@stanzabot stanzabot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency update for AWS SDK Cognito Identity requires careful consideration of version alignment and dependency management:

  1. Version Alignment Issue:
  • The PR updates cognitoidentity to version 2.30.3
  • However, cognitoidentityprovider remains at version 2.29.52
  • The AWS SDK BOM is defined at version 2.30.2
  1. Recommendations:
  • Consider updating all AWS SDK components together to maintain consistency
  • Align with the BOM version (2.30.2) rather than using an individual version (2.30.3)
  • Update the related cognitoidentityprovider dependency to the same version
  1. Best Practices:
  • When using a BOM (Bill of Materials), prefer to omit individual version numbers and let the BOM manage versions
  • Keep related AWS SDK components at the same version to ensure compatibility
  • Document any specific reason for version divergence if necessary

While this update is likely safe as a minor version bump, aligning versions across related AWS SDK components would improve maintainability and reduce potential compatibility issues.


Powered by Stanza

Available commands `@stanza-ai review` - Re-review the PR `@stanza-ai ` - Chat with the code review agent

Comment on lines 1142 to 1146
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>cognitoidentity</artifactId>
<version>2.29.52</version>
<version>2.30.3</version>
</dependency>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the explicit version here and letting it be managed by the AWS SDK BOM defined in the dependencyManagement section. This ensures consistent versioning across AWS SDK components.

Additionally, note that this version (2.30.3) is newer than the BOM version (2.30.2) and differs from cognitoidentityprovider (2.29.52). Consider aligning all AWS SDK versions for better maintainability.

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 23, 2025

Superseded by #1685.

@dependabot dependabot bot closed this Jan 23, 2025
@dependabot dependabot bot deleted the dependabot/maven/development/software.amazon.awssdk-cognitoidentity-2.30.3 branch January 23, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants