[trace-view] Added support for displaying disassembly view #20942
+3,432
−240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for viewing disassembly of Move source code when available. It does not use DAP's 'disassemblyRequest` feature as it does not seem mature enough to be used in our production setting. The particular problems discovered when trying to use it were:
disassemblyRequest
)The gist of this solution is to maintain two views of the trace state, one reflecting "source" execution and one (optional), reflecting "bytecode" execution". The two main differences between these views are:
Breakpoints are also handles separately for different views (i.e., source/bytecode-level breakpoints only work in frames that show source/bytecode, respectively).
Test plan
A new test for disassembly-level stepping, breakpoints and variable display has been added. All remaining tests must pass