Fix configure tasks loop

handlers/main.yml

@@ -3,8 +3,3 @@
 - name: Daemon reload
   systemd:
     daemon_reload: yes
-
-- name: Restart redis
-  systemd:
-    state: restarted
-    name: "{{ service_name }}"

tasks/cluster.yml

@@ -1,4 +1,5 @@
 ---
+
 - name: Set redis cluster command
   set_fact:
     redis_cluster_command: >-
@@ -27,12 +28,12 @@
       {% endif %}
   tags: redis_cluster
 
 - name: print redis command
   debug:
     var: redis_cluster_command
   tags: redis_cluster
 
 - name: Get redis cluster info
   command: "redis-cli -h {{ ansible_default_ipv4.address|default(ansible_all_ipv4_addresses[0]) }} -p {% if redis_configurations[0]['redis_tls_cluster'] is defined and redis_configurations[0]['redis_tls_cluster'] == 'yes' %} {{ redis_configurations[0]['redis_tls_port'] }} {% else %} {{ redis_configurations[0]['redis_port'] }} {% endif %} {% if redis_configurations[0]['redis_tls_cluster'] is defined and redis_configurations[0]['redis_tls_cluster'] == 'yes' %} --tls --cert {{ redis_configurations[0]['redis_tls_cert_file'] }} --key {{ redis_configurations[0]['redis_tls_key_file'] }} --cacert {{ redis_configurations[0]['redis_tls_ca_cert_file'] }} {% endif %} -a {{ redis_requirepass }} CLUSTER INFO"
   register: cluster_info
   changed_when: false

tasks/configure.yml

@@ -1,19 +1,22 @@
 ---
-- name: "Set redis service for {{ item.redis_instance_name }}"
+
+- name: "Set redis service"
   template:
     src: redis.service.j2
     dest: "{{ redis_systemd_directory }}/{{ item.redis_instance_name }}.service"
     mode: '0644'
     owner: root
     group: root
   when: "ansible_service_mgr == 'systemd'"
-  notify:
-    - Daemon reload
+  loop: "{{ redis_configurations | default([]) }}"
+  loop_control:
+    label: "{{ item.redis_instance_name }}"
+  notify: Daemon reload
 
 - name: Flush handlers
   meta: flush_handlers
 
-- name: "Create redis config directory for {{ item.redis_instance_name }}"
+- name: "Create redis config directory"
   file:
     path: "{{ redis_config_directory }}"
     state: directory
@@ -23,25 +26,33 @@
     setype: redis_conf_t
   when: redis_config_directory != "/etc"
 
-- name: "Set service name {{ item.redis_instance_name }}"
-  set_fact:
-    service_name: "{{ item.redis_instance_name }}.service"
-
-- name: "Set redis config for {{ item.redis_instance_name }}"
+- name: "Set redis config"
   template:
     src: redis.conf.j2
     dest: "{{ redis_config_directory }}/{{ item.redis_instance_name }}.conf"
     owner: "{{ redis_user_name }}"
     group: "{{ redis_group_name }}"
     mode: '0660'
     setype: redis_conf_t
-  notify: Restart redis
+  register: redis_config
+  loop: "{{ redis_configurations | default([]) }}"
+  loop_control:
+    label: "{{ item.redis_instance_name }}"
+
+- name: "Restart redis service(s) if config changed"
+  systemd:
+    state: restarted
+    name: "{{ item.redis_instance_name }}"
+  when: redis_config.changed
+  loop: "{{ redis_configurations | default([]) }}"
+  loop_control:
+    label: "{{ item.redis_instance_name }}"
 
-- name: "Start redis service {{ item.redis_instance_name }}"
+- name: "Start and enable redis service(s)"
   systemd:
     state: started
-    name: "{{ service_name }}"
+    name: "{{ item.redis_instance_name }}"
     enabled: yes
-
-- name: Flush handlers
-  meta: flush_handlers
+  loop: "{{ redis_configurations | default([]) }}"
+  loop_control:
+    label: "{{ item.redis_instance_name }}"

tasks/main.yml

@@ -77,7 +77,6 @@
     apply:
       tags: redis_configuration
   tags: redis_configuration
-  loop: "{{ redis_configurations | default([]) }}"
 
 - name: Build a cluster
   import_tasks: cluster.yml