Merge pull request #83 from NETWAYS/update-linter

Update linter config

.golangci.yml

@@ -11,9 +11,13 @@ issues:
     - path: 'main.go'
       linters:
         - nosnakecase
+        - funlen
     - path: 'hp/ilo/firmware.go'
       linters:
         - wastedassign
+    - path: 'snmp/snmpwalk.go'
+      linters:
+        - funlen
 
 linters:
    enable-all: true
@@ -45,7 +49,10 @@ linters:
      - varnamelen
      - wrapcheck
 linters-settings:
-   estif:
-     min-complexity: 4
-   maligned:
-     suggest-new: true
+  estif:
+    min-complexity: 4
+  maligned:
+    suggest-new: true
+  funlen:
+    statements: 65
+    ignore-comments: true

Makefile

@@ -1,7 +1,7 @@
 .PHONY: test coverage lint vet
 
 build:
-	go build
+	export CGO_ENABLED=0; go build
 lint:
 	go fmt $(go list ./... | grep -v /vendor/)
 vet:

main.go

@@ -67,7 +67,6 @@ affected hardware. There is ABSOLUTELY NO WARRANTY, see the license!
 `
 
 // Check for HP Controller CVEs via SNMP
-// nolint: funlen
 func main() {
 	config := check.NewConfig()
 	config.Name = "check_hp_firmware"

snmp/snmpwalk.go

@@ -50,7 +50,6 @@ func ReadWalk(r io.Reader) (pduList WalkData, err error) {
 	return
 }
 
-// nolint: funlen
 func ParseWalkLine(line string) (pdu *gosnmp.SnmpPDU, err error) {
 	parts := strings.SplitN(line, " = ", 2)
 

version.go

@@ -2,15 +2,13 @@ package main
 
 import "fmt"
 
-// nolint: gochecknoglobals
 var (
 	// These get filled at build time with the proper vaules
 	version = "development"
 	commit  = "HEAD"
 	date    = "latest"
 )
 
-//goland:noinspection GoBoolExpressions
 func buildVersion() string {
 	result := version