![REVIEW 2 & 3 ] (1) ruff.spell-check fixed all files, (2) ruff.format files excluded, and (3) ruff.lint files excluded. (4) Updated Celeris wave-solver. #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ examples) , update WorkflowApplications.json accordingly.
…ser-input and hosted within app repos (e.g. HydroUQ/Examples) later
…che --add-noqa ; ruff format --no-cache
…ronment unless there is an ImportError
…e -f, -d, and -b for the config JSON filename, directory containing input files, and bathymetry filename. Order enforced temporarily (python3 ./setrun.py -f config.json -d ./examples/CrescentCity -b bathy.txt)
…icial wind waves and a shorter period / higher amplitude tsunami wave (1500 -> 1000sec, 1 -> 2.3m) so that local PC's with GPU will take around 3-10 minutes to simulate
…milar to WebGPU version. Added in OSU_Seaside example (includes Lynett et al 2007 experimental parcel-scale buildings in a town), eventually apply BRAILS++ to generate custom inventories as a displacement map on the bathymetry / infer the existing scaled building properties and perimeters to allow NLSW / Boussinesq wave load determination
…n variables in DRM / Celeris
…ng ruff feedback on new PRs as they fail. Would lint-format them myself, but don't want to risk breaking anyone's code.
… PRs from passing). Please review and re-include them.
JustinBonus
changed the title
…S / LAPACK on Windows VS
…ac (may be better to brew install or hardcode typical header path for mac instead of <omp.h> )
…lude/library flag style for cmake configure on mac and Ubuntu
…conan install to configure BLAS and LAPACK library/include instead of hardcoded path
…ee if it resolves <omp.h>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 & 3. Specific files and directories excluded from ruff.format and ruff.lint as they prevented new PRs from getting green checkmarks.
After the Symposium, may be good to have a policy for new PRs passing checks and which ruff flags (--add-noqa / --fix / --unsafe-fixes) can be used on important files. (@fmckenna @zsarnoczay @ioannis-vm)
Please review and re-include below in pyproject.toml as they are fixed (especially whale/main.py):
Directories:
"modules/performRegionalEventSimulation/regionalGroundMotion",
"modules/performSIMULATION/capacitySpectrum"
Files:
"modules/Workflow/whale/main.py",
"modules/createAIM/INP_FILE/INP_FILE.py",
"modules/createEVENT/IsolatedBuildingCFD/setup_case.py",
"modules/createEVENT/shakeMapEvent/shakeMapEvent.py",
"modules/performREC/transportation.py",
"modules/systemPerformance/REWET/REWET_Wrapper.py",
"modules/systemPerformance/ResidualDemand/run_residual_demand.py",
"modules/systemPerformance/ResidualDemand/transportation.py",
"modules/tools/BRAILS/runBrailsTransp.py",
"modules/performUQ/SimCenterUQ/UQengine.py",
"modules/performUQ/UCSD_UQ/runTMCMC.py",
"modules/performUQ/common/uq_utilities.py",
"modules/performUQ/dakota/DakotaUQ.py"
[Sample 1]
[Sample 2]
