Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GUIDs #7409

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jobermayr
Copy link
Contributor

First I put clsids.txt and iids.txt to guids.txt

Then I updated from SDK 10.0.26100.1742 and WDK 10.0.26100.2454 (own python scripts) and keep all possible names separated by |.

@ryanmkurtz
Copy link
Collaborator

Unfortunately, this is unreviewable in its current state.

Why rename things?

@jobermayr
Copy link
Contributor Author

jobermayr commented Jan 26, 2025

Unfortunately, this is unreviewable in its current state.

It is easy (just review scripts guid_export and guid_merge):
First commit:

$ cat Ghidra/Features/Base/data/typeinfo/win32/msvcrt/{clsids.txt,guids.txt,iids.txt} | sort -u > Ghidra/Features/Base/data/typeinfo/win32/msvcrt/guids.txt 
$ rm Ghidra/Features/Base/data/typeinfo/win32/msvcrt/{clsids.txt,iids.txt}

Second commit
Copy Ghidra and Win SDK/WDK Include dir to /tmp

$ cd /tmp/ghidra/Ghidra/Features/Base/data/typeinfo/win32/msvcrt
$ ./guid_export
$ ./guid_merge

Why rename things?

Files:
It is easier to handle just one file. AFAIK Ghidra doesn't create classes or interfaces an so there is no need to split them.

Names for GUIDs:
If MS uses different names for them Ghidra should also do so. | is a good to separate them ;)

@astrelsky
Copy link
Contributor

Maybe it is worth making it possible for the user to add GUIDs without having to edit the guids.txt file in the Ghidra installation. I'm constantly overwriting it to add around 11000 GUIDs from EDK2 for UEFI analysis, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants