Searchable dropdown, radio button, bug fixes #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alycejenni
commented
Jan 23, 2025
alycejenni
commented
- adds two new components: a searchable dropdown and a radio button
- the radio button was necessary for implementing the searchable dropdown, and was also something we were going to implement anyway (Implement radio buttons #42)
- the searchable dropdown replaces what the autocomplete (erroneously) used to be (When you select an option from the autocomplete options list you get the value in the textbox not the label #38)
- autocomplete suggestions are now just a simple list of values (When you select an option from the autocomplete options list you get the value in the textbox not the label #38)
- debouncing now works for (hopefully) all components (Debouncing doesn't seem to work on autocomplete (and maybe components?) #36)
- keyboard nav has been either fixed or improved for multiselect
- fixed label truncation in multiselect
- checkbox/radio labels take up remaining space when aligned to the right (if no help text is present), so the full width of multiselect/dropdown options is now clickable
the "change" event on ZoaInput (i.e. the one the user is probably listening to) is triggered by "update:modelValue" from the nested input component. This change event was being debounced by 0ms because there's no delay on the wrapper, and the update event wasn't being debounced at all, so there was effectively no delay/debounce on the whole chain. Closes: #36
autocomplete is not a dropdown; what you type should be the value you get (even if you don't click an option). Partially fixes #38.
same as multiselect search: basic fuzzy string filtering, can be disabled to implement custom search, disabled by default
to clarify purpose and match other input types (i.e. dropdown, autocomplete)
needed to support searchable dropdown. Closes: #42
not sure what the goal was before (it didn't actually seem to do anything), but this makes more sense
If there's no help text and the label is on the right, the label should take up the remaining space. This is useful for dropdowns/multiselects so that the whole item (mostly) is clickable rather than just the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.