Playwright 1.49.1 #358638
Open
Playwright 1.49.1 #358638
+171
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: nixos
13 tasks
wegank
added
the
2.status: merge conflict
1 task
kalekseev
force-pushed
the
playwright-149
branch
from
3d6bd42 to
03ba451
Compare
ofborg
bot
removed
the
2.status: merge conflict
kalekseev
force-pushed
the
playwright-149
branch
from
03ba451 to
d030600
Compare
|
@ofborg test playwright-python |
|
Just for information #374064 |
13 tasks
kalekseev
force-pushed
the
playwright-149
branch
from
d030600 to
3220e9b
Compare
kalekseev
force-pushed
the
playwright-149
branch
from
3220e9b to
be322ba
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
The code is on top of #349469
Playwright 1.49 introduced new browser
chromium_shellthat used by default for chromium headless mode microsoft/playwright#33566.Looks like it's temporary while they are testing new headless version embeded into chrome. The new version can be enabled with channel=chrome (switched to it in test).
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.