Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia_111{,-bin}: 1.11.1 -> 1.11.2, julia_19{,-bin}: drop #361178

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Dec 2, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao NickCao changed the title julia_111{,-bin}: 1.11.1 -> 1.11.2 julia_111{,-bin}: 1.11.1 -> 1.11.2, julia_19{,-bin}: drop Dec 2, 2024
@NickCao
Copy link
Member Author

NickCao commented Dec 2, 2024

@ofborg build julia_111 julia_111-bin

@NickCao NickCao requested a review from thomasjm December 4, 2024 15:24
Copy link
Contributor

@thomasjm thomasjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

julia_111 looks good, with 8 package failures out of 1000.

julia_111-bin is failing on all package builds. Actually, it's also failing on master with the same issue. The main error seems to be this:

> nix run --impure --expr 'with import ./. {}; julia_111-bin.withPackages ["Plots"]' -L
...
LoadError: GitError(Code:ERROR, Class:SSL, failed to load CA certificates: 0xffffc200 - PK - Read/write of file failed)
...
ERROR: Failed to precompile Pkg [44cfe95a-1eb2-52ea-b672-e2afdf69b78f] to "/build/home/.julia/compiled/v1.11/Pkg/jl_z0P6VE".

It probably doesn't need to block this PR, but Pkg-related stuff in julia_111-bin seems to have big problems at the moment (cf also #350590).

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@thomasjm thomasjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I do still see these errors that we had with julia_111-bin before, any idea what it's about?

[nix-shell:~/.cache/nixpkgs-review/pr-361178/nixpkgs]$ nix run .#julia_111-bin
warning: Git tree '/home/tom/.cache/nixpkgs-review/pr-361178/nixpkgs' is dirty
[ Info: Precompiling InteractiveUtils [b77e0a4c-d291-57a0-90e8-8db25a27a240] (cache misses: ocachefile invalid checksum (1), mismatched flags (1))
[ Info: Precompiling REPL [3fa0cd96-eef1-5676-8a61-b3b8758bbffb] (cache misses: wrong dep version loaded (1), mismatched flags (1))

@NickCao
Copy link
Member Author

NickCao commented Dec 6, 2024

I do still see these errors that we had with julia_111-bin before, any idea what it's about?

Not yet, I will investigate.

@NickCao NickCao merged commit d4297d0 into NixOS:master Dec 6, 2024
34 of 36 checks passed
@NickCao NickCao deleted the julia_111 branch December 6, 2024 00:00
@vbgl
Copy link
Contributor

vbgl commented Jan 22, 2025

Can we backport this to 24.11?

@vbgl vbgl added the backport release-24.11 Backport PR automatically label Jan 23, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 23, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants