Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init grist core at 1.3.2 #376176

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

Scandiravian
Copy link

This is based on the work done in #305019 and #322633. I've added some additional changes to the service and changed the buildPhase to bring the output size down with a few hundred MiB.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jan 23, 2025
@Scandiravian
Copy link
Author

@bendlas and @soyouzpanda this is based on a lot of your work, so let me know if this is an issue for you.

I've added myself as a maintainer to the package and module; if you would like to be added as maintainers, please let me know as well.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 23, 2025
@Scandiravian Scandiravian force-pushed the init-grist-core branch 2 times, most recently from 0d75671 to f0923d1 Compare January 23, 2025 17:29
soyouzpanda and others added 2 commits January 23, 2025 18:30
Co-authored-by: Raito Bezarius <[email protected]>
Basic smoketest for the gVisor sandboxing.

Signed-off-by: Raito Bezarius <[email protected]>
@soyouzpanda
Copy link
Contributor

image

@Scandiravian
Copy link
Author

image

@soyouzpanda I'm not sure I follow - could you explain what you mean by this? 😕

@soyouzpanda
Copy link
Contributor

image

@soyouzpanda I'm not sure I follow - could you explain what you mean by this? 😕

I do not want my work to be used in an open source project that collaborates with weapon makers and fascists, that's all.

@Scandiravian
Copy link
Author

Scandiravian commented Jan 23, 2025

I do not want my work to be used in an open source project that collaborates with weapon makers and fascists, that's all.

@soyouzpanda I hear what you're saying. I don't want to get into a big discussion, but suffice to say that I understand your point of view and where you're coming from.

I can remove the commits that I cherry-picked from your PR and rewrite those parts myself. I can't guarantee that it won't be somewhat similar to the work you made, since there's a limited number of ways to configure things in Nix, but it will remove your association from the history. Would that be acceptable to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants