-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init grist core at 1.3.2 #376176
base: master
Are you sure you want to change the base?
Init grist core at 1.3.2 #376176
Conversation
needed for grist-core
@bendlas and @soyouzpanda this is based on a lot of your work, so let me know if this is an issue for you. I've added myself as a maintainer to the package and module; if you would like to be added as maintainers, please let me know as well. |
0d75671
to
f0923d1
Compare
Co-authored-by: Raito Bezarius <[email protected]>
Basic smoketest for the gVisor sandboxing. Signed-off-by: Raito Bezarius <[email protected]>
f0923d1
to
1cff416
Compare
@soyouzpanda I'm not sure I follow - could you explain what you mean by this? 😕 |
I do not want my work to be used in an open source project that collaborates with weapon makers and fascists, that's all. |
@soyouzpanda I hear what you're saying. I don't want to get into a big discussion, but suffice to say that I understand your point of view and where you're coming from. I can remove the commits that I cherry-picked from your PR and rewrite those parts myself. I can't guarantee that it won't be somewhat similar to the work you made, since there's a limited number of ways to configure things in Nix, but it will remove your association from the history. Would that be acceptable to you? |
This is based on the work done in #305019 and #322633. I've added some additional changes to the service and changed the
buildPhase
to bring the output size down with a few hundred MiB.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.