nixos/wrappers: add per-wrapper enable option #376196
Open
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is possible to globally enable or disable security wrappers, it isn't possible to disable only a subset of them. Consequently, users will have to overwrite the security wrappers completely and re-add the desired subset in case they want to disable a subset of those set up by the NixOS modules. Address this usecase by adding a new per-wrapper enable option.
github-actions
bot
added
6.topic: nixos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is possible to globally enable or disable security wrappers, it isn't possible to disable only a subset of them. Consequently, users will have to overwrite the security wrappers completely and re-add the desired subset in case they want to disable a subset of those set up by the NixOS modules.
Address this usecase by adding a new per-wrapper enable option.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.