Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] website_sale_order_cancel: New module website_sale_order_cancel #994

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[15.0][ADD] website_sale_order_cancel: New module website_sale_order_cancel #994

merged 1 commit into from
Jan 15, 2025

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Dec 9, 2024 •
edited
Loading

This module allows customers to cancel confirmed sales orders directly from the Odoo portal using a simple confirmation modal. Cancellation is restricted based on a configurable period before the sale order's scheduled date.

cc https://github.com/APSL 164428

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

@ppyczko ppyczko marked this pull request as draft December 9, 2024 12:37
@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch 7 times, most recently from c7c258d to 0b82494 Compare December 10, 2024 08:09
@ppyczko
Copy link
Author

ppyczko commented Dec 10, 2024

Hi @pedrobaeza @chienandalu, sorry to bother you. I'm facing an issue with the tour and I can't get the tests to pass. Do you have any suggestions or ideas on how to resolve this? I’d really appreciate your help. Thank you!

The error in question: https://github.com/OCA/e-commerce/actions/runs/12251915314/job/34177467304?pr=994#step:8:2487

@pedrobaeza
Copy link
Member

Sorry, I can't help in this.

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch from 0b82494 to a23c1af Compare December 10, 2024 15:09
@ppyczko
Copy link
Author

ppyczko commented Dec 10, 2024

Sorry, I can't help in this.

Thank you @pedrobaeza anyways, finally figured it out. I was following this guide and, in the Python section, it says you have to specify 'your_module.your_tour_name':

imagen

Well, removing 'your_module' was enough to solve it, kinda misleading. 😅
Thank you for your time!

@ppyczko ppyczko marked this pull request as ready for review December 10, 2024 15:34
@pedrobaeza pedrobaeza added this to the 15.0 milestone Dec 10, 2024
mpascuall
mpascuall approved these changes Dec 11, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

peluko00
peluko00 approved these changes Dec 11, 2024
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch 2 times, most recently from 69c6486 to cc8f5ae Compare December 17, 2024 14:28
BernatObrador
BernatObrador approved these changes Dec 23, 2024
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch 2 times, most recently from b5f205d to 3ef11be Compare January 8, 2025 09:46
@ppyczko
Copy link
Author

ppyczko commented Jan 8, 2025

Could you please @mpascuall @peluko00 @BernatObrador review again after the latest modifications? Thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mpascuall
mpascuall approved these changes Jan 8, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

peluko00
peluko00 approved these changes Jan 8, 2025
View reviewed changes
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppyczko
Copy link
Author

ppyczko commented Jan 14, 2025

Hi @pedrobaeza, sorry to ping directly. Could you please review this when you have a moment? Thank you!

@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch 2 times, most recently from d657533 to 8948ff2 Compare January 15, 2025 07:28
@ppyczko ppyczko force-pushed the 15.0-add-website_sale_order_cancel branch from 8948ff2 to 3ff66a6 Compare January 15, 2025 07:51
@ppyczko ppyczko mentioned this pull request Jan 15, 2025
Open
pedrobaeza
pedrobaeza approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-994-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 276323e. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit fc79ff7 into OCA:15.0 Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpascuall mpascuall mpascuall approved these changes

@peluko00 peluko00 peluko00 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@BernatObrador BernatObrador Awaiting requested review from BernatObrador

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ppyczko @pedrobaeza @OCA-git-bot @peluko00 @BernatObrador @mpascuall