Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] partner_tier_validation #1488

Merged
merged 30 commits into from
Jun 29, 2023
Merged

[16.0][MIG] partner_tier_validation #1488

merged 30 commits into from
Jun 29, 2023

Conversation

Urvisha-OSI
Copy link
Contributor

@Urvisha-OSI Urvisha-OSI commented Mar 20, 2023 •
edited by dreispt
Loading

dreispt and others added 30 commits March 20, 2023 16:35
@dreispt @Urvisha-OSI
[ADD] partner_tier_validation
ccbb503
@Freni-OSI @Urvisha-OSI
[14.0][MIG]partner_tier_validation
f508d8e
@Freni-OSI @Urvisha-OSI
[14.0][IMP]Improved partner_tier_validation
c4100d7
@oca-travis @Urvisha-OSI
[UPD] Update partner_tier_validation.pot
512cc30
@dreispt @Urvisha-OSI
[FIX] partner_tier_validation: workflow was not working
1e2be3a
@oca-travis @Urvisha-OSI
[UPD] Update partner_tier_validation.pot
6e59472
@OCA-git-bot @Urvisha-OSI
[UPD] README.rst
c601e68
@OCA-git-bot @Urvisha-OSI
partner_tier_validation 14.0.1.1.0
b4d73bc
@patrickrwilson @Urvisha-OSI
[IMP]
2559cbe 
- Added new optional tier definition for is_company = true.
- Added auto active if no validation needed during create.
- Added reset validation during write for specific fields.

[FIX] Code White Space Formatting

[IMP] Reviewer Suggestions

[IMP] Added Tests
@oca-travis @Urvisha-OSI
[UPD] Update partner_tier_validation.pot
af24c53
@OCA-git-bot @Urvisha-OSI
[UPD] README.rst
a7d3517
@OCA-git-bot @Urvisha-OSI
partner_tier_validation 14.0.2.0.0
acc61ab
@victoralmau @Urvisha-OSI
[FIX] partner_tier_validation: Defer rule activation for compatibility
c4d2bca 
Having this rule activated by default in tests environments makes other tests to fail due to the additional constraint not expected by them, so what we are doing is:

- Having the rule deactivated by default.
- On a post-init hook, we activate it only if we are not in a test environment.
- On own modules tests, we activate it as well

TT30292
@oca-travis @Urvisha-OSI
[UPD] Update partner_tier_validation.pot
99dd82c
@dreispt @Urvisha-OSI
[REF] partner_tier_validation: do not archive, depend on partner_stage
59cc95e
@oca-travis @Urvisha-OSI
[UPD] Update partner_tier_validation.pot
65b2a51
@oca-travis @Urvisha-OSI
[UPD] Update partner_tier_validation.pot
0b30249
@OCA-git-bot @Urvisha-OSI
[UPD] README.rst
a6dc00e
@OCA-git-bot @Urvisha-OSI
partner_tier_validation 14.0.3.0.0
b6a5626
@dreispt @Urvisha-OSI
[FIX] partner_tier_validation: create does not need custom code, rest…
8b70e95 
…art validation on controlled field changes
@dreispt @Urvisha-OSI
[FIX] partner_tier_validation: fix tests
605a8b9
@OCA-git-bot @Urvisha-OSI
[UPD] README.rst
5c24026
@OCA-git-bot @Urvisha-OSI
partner_tier_validation 14.0.3.0.1
0d25633
@oca-travis @Urvisha-OSI
[UPD] Update partner_tier_validation.pot
4984897
@patrickrwilson @Urvisha-OSI
[IMP] partner_tier_validation (Prevent bypass)
db4963d 
This prevents a scenario where a user can bypass validation by moving the partner to a 'cancel' stage and then moving it back to confirmed.
@OCA-git-bot @Urvisha-OSI
partner_tier_validation 14.0.3.0.2
ba7e1d4
@BT-dmontull @Urvisha-OSI
[IMP] partner_tier_validation: black, isort, prettier
7ae06f4
@BT-dmontull @Urvisha-OSI
[15.0][MIG] partner_tier_validation: Migration to 15.0
e1a6bf6
@Urvisha-OSI
[IMP] partner_tier_validation: pre-commit stuff
737caf7
@Urvisha-OSI
[MIG] partner_tier_validation: Migrated to 16.0
5190843
@dreispt
Copy link
Member

dreispt commented Jun 29, 2023

Probably was depending on OCA/server-ux#540
Trying a merge.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1488-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 29, 2023
@OCA-git-bot
Merge PR #1488 into 16.0
eaa23c1 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1488-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

dreispt commented Jun 29, 2023 •
edited
Loading

Tests fail because of dependency on #1487, that was just merged.
Retrying.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1488-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5035426 into OCA:16.0 Jun 29, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d492a41. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houzefa-abba houzefa-abba houzefa-abba approved these changes

@dreispt dreispt dreispt approved these changes

@alexis-via alexis-via alexis-via approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Urvisha-OSI @dreispt @OCA-git-bot @alexis-via @houzefa-abba @Freni-OSI @oca-travis @patrickrwilson @victoralmau @BT-dmontull