Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] purchase_requisition_tier_validation: Migration to 16.0 #1738

Merged
merged 16 commits into from
Feb 27, 2023
Merged

[MIG] purchase_requisition_tier_validation: Migration to 16.0 #1738

merged 16 commits into from
Feb 27, 2023

Conversation

dzungtran89
Copy link
Contributor

No description provided.

@dzungtran89 dzungtran89 mentioned this pull request Feb 1, 2023
Open
53 tasks
@rven
Copy link

rven commented Feb 17, 2023

Isn't this already migrated with #1671?

@dzungtran89
Copy link
Contributor Author

Isn't this already migrated with #1671?

No, they are two diff modules

@yankinmax
Copy link
Contributor

@dzungtran89 pls rebase on latest 16.0 updates. pre-commit should be fixed now

leemannd
leemannd approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Minor comment, test could be moved to setupClass

cyrilmanuel
cyrilmanuel approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@cyrilmanuel cyrilmanuel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :
pre-commit can be resolve regarding this :

OCA/oca-addons-repo-template#185

create new PR: checkout the branch (eg: 16.0) fork it and run copier -f update

ps-tubtim and others added 16 commits February 20, 2023 18:26
@ps-tubtim @dzungtran89
[12.0][ADD] purchase_requisition_tier_validation
2e1b73d
@oca-travis @dzungtran89
[UPD] Update purchase_requisition_tier_validation.pot
05a0300
@OCA-git-bot @dzungtran89
[UPD] README.rst
ab628af
@ps-tubtim @dzungtran89
[IMP] purchase_requisition_tier_validation: black, isort
96d0d6f
@ps-tubtim @dzungtran89
[MIG] purchase_requisition_tier_validation: Migration to 13.0
eb236fb
@oca-travis @dzungtran89
[UPD] Update purchase_requisition_tier_validation.pot
9c35f3f
@OCA-git-bot @dzungtran89
pre-commit update
25d7fdc
@dong-z @dzungtran89
Added translation using Weblate (Chinese (Simplified))
6135672
@dong-z @dzungtran89
Translated using Weblate (Chinese (Simplified))
d4cca46 
Currently translated at 100.0% (13 of 13 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_requisition_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_requisition_tier_validation/zh_CN/
@dong-z @dzungtran89
Translated using Weblate (Chinese (Simplified))
a30305a 
Currently translated at 100.0% (13 of 13 strings)

Translation: purchase-workflow-13.0/purchase-workflow-13.0-purchase_requisition_tier_validation
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-13-0/purchase-workflow-13-0-purchase_requisition_tier_validation/zh_CN/
@aphon61bank @dzungtran89
[14.0][MIG] purchase_requisition_tier_validation
f6390c7
@Camille0907 @dzungtran89
[MIG] purchase_requisition_tier_validation: Migration to 15.0
dd1ad49
@dzungtran89
[UPD] Update purchase_requisition_tier_validation.pot
27ebe15
@OCA-git-bot @dzungtran89
[UPD] README.rst
1f5e906
@dzungtran89
[IMP] purchase_requisition_tier_validation: black, isort, prettier
b89a330
@dzungtran89
[MIG] purchase_requisition_tier_validation: Migration to 16.0
90eeba3
@dzungtran89 dzungtran89 force-pushed the 16.0-purchase_requisition_tier_validation branch from 5032f5f to 90eeba3 Compare February 20, 2023 11:29
@dzungtran89
Copy link
Contributor Author

dzungtran89 commented Feb 20, 2023 •
edited
Loading

Good day, thank you for the review, the PR has been updated

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link

/ocabot migration purchase_requisition_tier_validation

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 27, 2023
@simahawk
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1738-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 112cf75 into OCA:16.0 Feb 27, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6488966. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankinmax yankinmax yankinmax approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@leemannd leemannd leemannd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.