Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: code simplification #10368

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5921

Describe changes:

  • http: code simplification to avoid one direct usage of htp_list_get
LIBHTP_BRANCH=pr/416

OISF/libhtp#416

Libhtp PR is not a requirement, but is related (code optimizations after release for the same redmine issue)

#10366 with typo in commit fixed

removing function unused parameter tx_id in HTPFileOpen
And using directly tx instead of its id in HTPFileOpenWithRange
@victorjulien victorjulien added this to the 8.0 milestone Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fe00ff) 82.52% compared to head (587915c) 82.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10368      +/-   ##
==========================================
- Coverage   82.52%   82.51%   -0.02%     
==========================================
  Files         978      978              
  Lines      272148   272145       -3     
==========================================
- Hits       224595   224563      -32     
- Misses      47553    47582      +29     
Flag Coverage Δ
fuzzcorpus 63.59% <100.00%> (-0.01%) ⬇️
suricata-verify 61.85% <85.71%> (-0.03%) ⬇️
unittests 62.83% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 101 111 109.9%
TREX_GENERIC_stats_chk
.capture.kernel_drops 0 244 0.00

Pipeline 18344

@victorjulien
Copy link
Member

Merged in #10413, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants