dpdk: add warning in configuration phase and minor DPDK refactoring v1 #10387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 12, 2024 21:25
|
Information: ERROR: QA failed on SURI_TLPW2_autofp_suri_time.
Pipeline 18389 |
| @@ -1550,7 +1578,7 @@ static void *ParseDpdkConfigAndConfigureDevice(const char *iface) | |||
| if (retval < 0) { // handles both configure attempts | |||
| iconf->DerefFunc(iconf); | |||
| if (rte_eal_cleanup() != 0) | |||
| FatalError("EAL cleanup failed: %s", strerror(-retval)); | |||
| FatalError("EAL cleanup failed (err: %s)", strerror(-retval)); | |||
There was a problem hiding this comment.
I don't see this as an improvement. The old scheme is as clear, while being less verbose. Would rather unify on that. This also matches use of strerror(errno) elsewhere in the code
There was a problem hiding this comment.
same for the rest of the PR
victorjulien
requested changes
Feb 13, 2024
|
continues in #10449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6739
Describe changes: