Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JA4 for TLS and QUIC -- v12 #10836

Closed
wants to merge 3 commits into from
Closed

JA4 for TLS and QUIC -- v12 #10836

wants to merge 3 commits into from

Conversation

satta
Copy link
Contributor

@satta satta commented Apr 14, 2024

Previous PR: #10829

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6379

Changes to previous PR:

  • Rebase against current master.
  • Use local copy of JA3 state flag to ensure consistency across multiple dependent checks.

SV_BRANCH=OISF/suricata-verify#1761

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 83.58209% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 82.73%. Comparing base (365a66a) to head (415f32c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10836      +/-   ##
==========================================
+ Coverage   82.67%   82.73%   +0.06%     
==========================================
  Files         928      931       +3     
  Lines      247912   248332     +420     
==========================================
+ Hits       204952   205461     +509     
+ Misses      42960    42871      -89     
Flag Coverage Δ
fuzzcorpus 64.13% <64.36%> (+0.13%) ⬆️
suricata-verify 62.13% <83.74%> (+0.12%) ⬆️
unittests 62.15% <44.34%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Apr 16, 2024
@victorjulien
Copy link
Member

Merged in #10856, thanks!

@satta satta deleted the 6379-ja4-v12 branch April 16, 2024 13:09
@catenacyber
Copy link
Contributor

Thank you Sascha :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants