Feat/6927 add unit tests v2 #10838
Feat/6927 add unit tests v2 #10838
Conversation
To better control the values within the variables and to prepare for the follow-up unit tests, the variable was moved into global scope and should accessed only by functions. This allows reinstantination of the variable value - needed for unit tests.
The function would incorrectly perform XOR operation. While it worked when the worker cores were occupying all cores, it is still not correct operation. The example might be when a core would be affined to only management and not worker threads. With the XOR operation it would set affinity to also worker set. (1 XOR 0 -> 1 where in fact the desired outcome is 0)
For the upcoming changes, skipping a unit test might be beneficial when testing a function that retrieves hardware data. This can e.g. depend on the number of CPU cores and systems that does not meet the required test criteria will need to omit the tests. The tests should always target minimal system requirements
… requirements of tests
…gnment Ticket: 6927
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10838 +/- ##
==========================================
- Coverage 82.83% 82.41% -0.42%
==========================================
Files 913 919 +6
Lines 246847 248831 +1984
==========================================
+ Hits 204474 205083 +609
- Misses 42373 43748 +1375
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 20058 |
| @@ -451,6 +452,8 @@ void LiveDeviceFinalize(void) | |||
| } | |||
| SCFree(ld); | |||
| } | |||
|
|
|||
| TAILQ_INIT(&pre_live_devices); // reset the list | |||
There was a problem hiding this comment.
Should it not be done in a separate "reset" function ?
Looks strange to see SomeFuncFinalize end with INIT
| @@ -88,10 +88,12 @@ ThreadsAffinityType * GetAffinityTypeFromName(const char *name); | |||
|
|
|||
| uint16_t AffinityGetNextCPU(ThreadsAffinityType *taf); | |||
| uint16_t UtilAffinityGetAffinedCPUNum(ThreadsAffinityType *taf); | |||
| #ifdef HAVE_DPDK | |||
| int UnitTestsUtilAffinityVerifyCPURequirement(void); | |||
There was a problem hiding this comment.
Is this function used outside of tests ?
There was a problem hiding this comment.
No, it is not. What do you imply? Ah, should it be guarded by #if defined UNIT_TEST?
There was a problem hiding this comment.
What do you imply? Ah, should it be guarded by #if defined UNIT_TEST?
Indeed, but trying to ask the question in a way that you found it yourself ;-)
| @@ -326,7 +326,7 @@ uint16_t UtilAffinityGetAffinedCPUNum(ThreadsAffinityType *taf) | |||
| */ | |||
| int UnitTestsUtilAffinityVerifyCPURequirement(void) | |||
| { | |||
| #if UNITTESTS && !defined __CYGWIN__ && !defined OS_WIN32 && !defined __OpenBSD__ && \ | |||
| #if defined(UNITTESTS) && !defined __CYGWIN__ && !defined OS_WIN32 && !defined __OpenBSD__ && \ | |||
There was a problem hiding this comment.
Looks like this line should have only been changed in one commit
|
On the next PR, please set a descriptive title. |
|
Follow up in #11494 |
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6927
Follow-up of: #10786
Describe changes:
v2
v1