next/396/20240415/v1 #10852
Merged
next/396/20240415/v1 #10852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As will be needed for tcp.mss
Support compressed proto and optional HDLC header. Bug: OISF#6942.
As we now support variable size headers, we can't use the old pointer. Replace with a flag.
No users of the pointer anymore, so remove it.
Recognize PPP_CCP, PPP_CBCP and PPP_COMP_DGRAM. Does not implement decoders for these record types, so these are logged as unsupported types. Was "wrong_type" before.
Issue: 6957 Rather than selecting the thread_id index by packets traveling to the server, use the flow flags. If the flow has been reversed, the second slot is represents the thread id to be used.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10852 +/- ##
==========================================
+ Coverage 82.83% 82.88% +0.04%
==========================================
Files 913 914 +1
Lines 246847 246936 +89
==========================================
+ Hits 204474 204671 +197
+ Misses 42373 42265 -108
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 20078 |
Expected, see #10844 (comment) |
This was referenced Apr 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1769