Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output notx 6846 v7 #10876

Closed
wants to merge 2 commits into from
Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6846

Describe changes:

  • output/alert: do not use tx_id 0 when there is no transaction

#10655 rebased to get attention

Ticket: 6846

This led to packet rules logging irrelevant app-layer data
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.93%. Comparing base (240e068) to head (969491a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10876      +/-   ##
==========================================
- Coverage   82.95%   82.93%   -0.02%     
==========================================
  Files         917      917              
  Lines      247367   247379      +12     
==========================================
- Hits       205198   205173      -25     
- Misses      42169    42206      +37     
Flag Coverage Δ
fuzzcorpus 64.48% <89.47%> (-0.03%) ⬇️
suricata-verify 62.29% <89.47%> (-0.03%) ⬇️
unittests 62.29% <36.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien added this to the 8.0 milestone Apr 17, 2024
@victorjulien
Copy link
Member

Merged in #10887, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants