Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor flow cleanups/20240613/v2 #11311

Closed

Conversation

inashivb
Copy link
Member

Link to ticket: https://redmine.openinfosecfoundation.org/issues/

Previous PR: #11302

Changes since v1:

  • rebased on top of latest master
  • clang fmt fixes done
  • cleanups to flow-timeout.c

*/
void FlowForceReassembly(void)
void FlowWorkToDoCleanup(void)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really happy with this name. Suggestions welcome.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (49ecf37) to head (0e112c0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11311      +/-   ##
==========================================
- Coverage   82.47%   82.47%   -0.01%     
==========================================
  Files         934      934              
  Lines      252270   252270              
==========================================
- Hits       208055   208054       -1     
- Misses      44215    44216       +1     
Flag Coverage Δ
fuzzcorpus 60.26% <42.85%> (-0.01%) ⬇️
livemode 18.76% <33.33%> (+<0.01%) ⬆️
pcap 43.74% <95.23%> (-0.04%) ⬇️
suricata-verify 61.32% <95.23%> (+<0.01%) ⬆️
unittests 59.92% <6.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@inashivb inashivb marked this pull request as ready for review June 17, 2024 13:04
@inashivb inashivb requested a review from victorjulien as a code owner June 17, 2024 13:04
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 642 664 103.43%

Pipeline 21106

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21123

@inashivb inashivb closed this Jun 21, 2024
@inashivb inashivb deleted the minor-flow-cleanups/20240613/v2 branch June 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants