Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert byte_extract keyword parser to Rust #11380

Closed
wants to merge 3 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #11344

Convert the byte_extract option parser from C to Rust.

Link to redmine ticket: 6873

Describe changes:

  • Refactor code in rust/src/detect to support re-usability
  • Implement the byte_extract parser in Rust, with unittests
  • Modify the existing byte_extract module to use the Rust parser

Updates:

  • Rebase

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: 6873

Refactor the enums for endian and base handling for broader use.
Implement the keyword parser in Rust.

Issue: 6873
This commit uses Option instead of Result.

Issue: 6873
@victorjulien
Copy link
Member

What was done about the alert deviation?

@ct0br0
Copy link

ct0br0 commented Jun 28, 2024

Talked with Jeff. Made an issue to track it. Still chasing the other issues going on right now with release qa-rebase and potential hardware issue.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21325

@jlucovsky
Copy link
Contributor Author

What was done about the alert deviation?

A QA re-run happened and there were no alert deviations.

@victorjulien victorjulien added this to the 8.0 milestone Jul 8, 2024
@victorjulien
Copy link
Member

Merged in #11447, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants