gen: Remove _AL_ usage in detect keywords #12433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `_AL_` usage in detect keywords for improved readability. Some of the HTTP rule keywords already had counterparts without using "_AL_". These rule keywords are the legacy content modifier keywords that now have sticky buffer equivalents. For these, "_AL_" was removed and a suffix was added to the #define: src/detect-engine-register.h:151: DETECT_HTTP_COOKIE_CM src/detect-engine-register.h:153: DETECT_HTTP_METHOD_CM src/detect-engine-register.h:161: DETECT_HTTP_HEADER_CM src/detect-engine-register.h:173: DETECT_HTTP_RAW_HEADER_CM src/detect-engine-register.h:175: DETECT_HTTP_URI_CM src/detect-engine-register.h:179: DETECT_HTTP_STAT_MSG_CM src/detect-engine-register.h:181: DETECT_HTTP_STAT_CODE_CM src/detect-engine-register.h:185: DETECT_HTTP_HOST_CM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12433 +/- ##
=======================================
Coverage 80.62% 80.63%
=======================================
Files 920 920
Lines 258697 258704 +7
=======================================
+ Hits 208566 208595 +29
+ Misses 50131 50109 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24278 |
victorjulien
approved these changes
Jan 20, 2025
Merged
|
Merged in #12436, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
_AL_usage in detect keywords for improved readability.Some of the HTTP rule keywords already had counterparts without using "AL". These rule keywords are the legacy content modifier keywords that now have sticky buffer equivalents.
For these, "AL" was removed and a suffix was added to the #define:
src/detect-engine-register.h:151: DETECT_HTTP_COOKIE_CM
src/detect-engine-register.h:153: DETECT_HTTP_METHOD_CM
src/detect-engine-register.h:161: DETECT_HTTP_HEADER_CM
src/detect-engine-register.h:173: DETECT_HTTP_RAW_HEADER_CM
src/detect-engine-register.h:175: DETECT_HTTP_URI_CM
src/detect-engine-register.h:179: DETECT_HTTP_STAT_MSG_CM
src/detect-engine-register.h:181: DETECT_HTTP_STAT_CODE_CM
src/detect-engine-register.h:185: DETECT_HTTP_HOST_CM
Describe changes:
DETECT_AL_toDETECT_, e.g.,DETECT_AL_APP_LAYER_EVENT->DETECT_APP_LAYER_EVENTAL_and suffix with_CM, e.gDETECT_AL_HTTP_HEADER->DETECT_HTTP_HEADER_CMProvide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=