lua: expose hash function to lua scripts - v1 #12437
Closed
+604
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12437 +/- ##
==========================================
+ Coverage 80.63% 80.67% +0.04%
==========================================
Files 920 921 +1
Lines 258704 258919 +215
==========================================
+ Hits 208595 208893 +298
+ Misses 50109 50026 -83
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24283 |
|
I think it looks good. |
|
I suppose one thing that will come up quickly, is how to keep state between invocations? Not something this PR should fix, but something to think about? |
jasonish
force-pushed
the
lua/hashlib/v1
branch
from
338b3a9 to
e93e1e0
Compare
Make all the hasher's have the same variants: - add hex digest for sha256 - add finalize to hex for sha1 - add hex digest for sha1
jasonish
force-pushed
the
lua/hashlib/v1
branch
from
e93e1e0 to
f4330e9
Compare
Expose md5, sha1, and sha256 to Lua scripts with
`require("suricata.hashing")`.
Ticket: 7073
jasonish
force-pushed
the
lua/hashlib/v1
branch
from
27488d9 to
8c0c382
Compare
jasonish
force-pushed
the
lua/hashlib/v1
branch
from
8c0c382 to
a8b9e2d
Compare
|
Information: QA ran without warnings. Pipeline 24316 |
|
Updated here and ready for final review: #12449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose md5, sha1, and sha256 to Lua scripts with
require("suricata.hashing").Draft as a few things are missing:
But does the API look OK? I put them all into the "suricata.hashing" namespace.
But we could also do something like
require("suricata.hashing.md5")to bemore fine grained.
Ticket: https://redmine.openinfosecfoundation.org/issues/7073
SV_BRANCH=OISF/suricata-verify#2247