Cleanup nits : unused macros, better depency in makefile, remove unnecesarry field out of SuricataContext #12456
+5
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make should rerun cbindgen if cbindgen.toml is modified
Just use a regular compile time rust export, instead of having a runtime definition through the SuricataContext structure
when compiling without unit tests detect-transform-base64.c:47:9: warning: macro is not used [-Wunused-macros] 47 | #define DETECT_TRANSFORM_FROM_BASE64_MODE_DEFAULT (uint8_t) Base64ModeRFC4648
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12456 +/- ##
==========================================
+ Coverage 80.63% 80.64% +0.01%
==========================================
Files 920 920
Lines 258704 258702 -2
==========================================
+ Hits 208595 208627 +32
+ Misses 50109 50075 -34
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
none, just cleanups
Describe changes:
some simple commits out of #12455