platform/NVMem:Fix stack overflow in _plat__NvInitFromStorage() on 64 bit architectures #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…b architectures The `UINT32 bytesRead` stack variable in _plat__NvInitFromStorage() is passed as fourth argument to `TEE_ReadObjectData()` which has following signature: TEE_Result TEE_ReadObjectData(TEE_ObjectHandle object, void *buffer, size_t size, size_t *count) This might cause stack overflow on 64b architectures where 64b-wide size_t value would be written to address of 32b-wide variable on stack. Signed-off-by: Lukas Janik <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
ljanik
force-pushed
the
bugfix/bad-type-in-plat-nv-init
branch
from
d063097 to
23d1f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UINT32 bytesReadstack variable declared in _plat__NvInitFromStorage() is passed as fourth parameter toTEE_ReadObjectData()` which has following signature:
The type mismatch might cause stack overflow on 64 bit architectures where 64b-wide
size_tvalue would be written to address of 32b-wide variable on stack.